Rename packrat field names - #728
Merged
Merged
Conversation
labbott
approved these changes
Sep 3, 2026
adamlouis
reviewed
Sep 3, 2026
| const PACKRAT_LAST_PANIC_PAYLOAD: &str = "cell.value.host_info.panic_payload"; | ||
| const PACKRAT_LAST_PANIC_STATE: &str = "cell.value.host_info.panic_state"; | ||
| const PACKRAT_BOOT_FAIL_PAYLOAD: &str = "cell.value.host_info.panic_payload"; | ||
| const PACKRAT_BOOT_FAIL_STATE: &str = "cell.value.host_info.panic_state"; |
There was a problem hiding this comment.
@jamesmunns are there tests we can add to catch issues like these moving forward?
Contributor
Author
There was a problem hiding this comment.
Yes, I'll add an issue to add this to our regression test suite. We have tests for older versions, but I didn't add one as we hadn't landed the hubris change yet when the humility PR did (which also fixed some other issues).
|
@jamesmunns This works on the affected systems - thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #727
In oxidecomputer/hubris@8011935 I changed the name of these fields after the humility PR landed, and didn't go back to change them.
This addresses that. We don't need to support the old names as that never landed in the main hubris tree.