Skip to content

[2/n] [wicketd] move RSS types to a new wicketd-commission-types crate#10807

Merged
sunshowers merged 7 commits into
mainfrom
sunshowers/spr/2n-wicketd-move-rss-types-to-a-new-wicketd-commission-types-crate
Jul 13, 2026
Merged

[2/n] [wicketd] move RSS types to a new wicketd-commission-types crate#10807
sunshowers merged 7 commits into
mainfrom
sunshowers/spr/2n-wicketd-move-rss-types-to-a-new-wicketd-commission-types-crate

Conversation

@sunshowers

@sunshowers sunshowers commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Part of RFD 710. These types are going to be part of the published API.

This is pure code movement with no functional changes.

Depends on:

@sunshowers
[spr] changes to main this commit is based on
709289a 
Created using spr 1.3.6-beta.1

[skip ci]
@sunshowers
[spr] initial version
15cf7cc 
Created using spr 1.3.6-beta.1
@sunshowers
fix intra-doc link
d6cc27d 
Created using spr 1.3.6-beta.1
@sunshowers
move tests to impls/
48bcc56 
Created using spr 1.3.6-beta.1
@sunshowers sunshowers mentioned this pull request Jul 13, 2026
Merged
@sunshowers
sunshowers requested a review from jgallagher July 13, 2026 04:45
@sunshowers
sunshowers requested a review from andrewjstone July 13, 2026 04:46
This was referenced Jul 13, 2026
Merged
Merged
Merged
@sunshowers
sunshowers changed the base branch from sunshowers/spr/main.2n-wicketd-move-rss-types-to-a-new-wicketd-commission-types-crate to main July 13, 2026 18:32
@sunshowers
rebase on main
3179ffa 
Created using spr 1.3.6-beta.1
@sunshowers
sunshowers enabled auto-merge (squash) July 13, 2026 18:33
@sunshowers
sunshowers disabled auto-merge July 13, 2026 19:39
@sunshowers

sunshowers commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

going to do some minor tweaks

@sunshowers
sunshowers enabled auto-merge (squash) July 13, 2026 20:40
@sunshowers
docs
62f4b04 
Created using spr 1.3.6-beta.1
@sunshowers
sunshowers disabled auto-merge July 13, 2026 22:58
@sunshowers
sunshowers enabled auto-merge (squash) July 13, 2026 22:59
@sunshowers
sunshowers merged commit a19e2e8 into main Jul 13, 2026
21 checks passed
@sunshowers
sunshowers deleted the sunshowers/spr/2n-wicketd-move-rss-types-to-a-new-wicketd-commission-types-crate branch July 13, 2026 23:16
sunshowers added a commit that referenced this pull request Jul 14, 2026
@sunshowers
[3/n] [wicketd-commission-types] reject unknown fields in UserSpecifi…
5e2a6a6 
…edPortConfig (#10808)

`serde(untagged)` is a bit fragile here. I'm not sure if we're going to
switch this to internal tagging in the future, but this code can be
removed if we make that change.

Depends on:

* #10806
* #10807
sunshowers added a commit that referenced this pull request Jul 15, 2026
@sunshowers
[4/n] [wicketd] dedup uploaded certificates (#10809)
ba55a47 
The `CertKeyDuplicateIgnored` variant was added in #3326 but was never
returned.

We could do something fancier here like try and key on some notion of
certificate identity, but I figure what really matters here is an
operator retry.

Depends on:

* #10806
* #10807
* #10808
sunshowers added a commit that referenced this pull request Jul 16, 2026
@sunshowers
[5/n] [wicketd-commission-types] slightly better docs for RSS types (#…
842f352 
…10810)

We're going to make this a published API, so let's add a little bit of
documentation. There are no functional changes.

Depends on:

* #10806
* #10807
* #10808
* #10809
sunshowers added a commit that referenced this pull request Jul 16, 2026
@sunshowers
[6/n] [wicket] import commission types directly instead of via wicket…
7c12eea 
…-common re-exports (#10811)

Remove the temporary shims added in #10807.

Depends on:

* #10806
* #10807
* #10808
* #10809
* #10810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewjstone andrewjstone andrewjstone approved these changes
@jgallagher jgallagher Awaiting requested review from jgallagher

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sunshowers @andrewjstone