[3/n] [wicketd-commission-types] reject unknown fields in UserSpecifiedPortConfig#10808
Merged
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
This was referenced Jul 13, 2026
andrewjstone
approved these changes
Jul 13, 2026
andrewjstone
left a comment
andrewjstone
left a comment
Contributor
There was a problem hiding this comment.
Great fix. Thank you!
Contributor
|
FYI, the main reason I used untagged here was so that the TOML config would be backwards compatible. Does that still hold with this change? |
Contributor
Author
Yeah. There's no change for correct configs. It's just incorrect ones now fail properly rather than silently becoming "auto". |
sunshowers
changed the base branch from
sunshowers/spr/main.3n-wicketd-commission-types-reject-unknown-fields-in-userspecifiedportconfig
to
main
July 13, 2026 23:22
Created using spr 1.3.6-beta.1
sunshowers
enabled auto-merge (squash)
July 13, 2026 23:23
sunshowers
disabled auto-merge
July 13, 2026 23:50
Created using spr 1.3.6-beta.1
sunshowers
enabled auto-merge (squash)
July 14, 2026 00:08
sunshowers
deleted the
sunshowers/spr/3n-wicketd-commission-types-reject-unknown-fields-in-userspecifiedportconfig
branch
July 14, 2026 06:59
sunshowers
added a commit
that referenced
this pull request
Jul 16, 2026
sunshowers
added a commit
that referenced
this pull request
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
serde(untagged)is a bit fragile here. I'm not sure if we're going to switch this to internal tagging in the future, but this code can be removed if we make that change.Depends on: