chore: fix eslint not working as it should#392
Merged
Conversation
|
Preview: https://packit-dashboard-pr-392.surge.sh (deployed at Fri 17 May 2024, 17:21 UTC) |
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 51s |
Venefilyn
added a commit
to Venefilyn/dashboard
that referenced
this pull request
Apr 7, 2024
Some dependencies to `useMemo` in ResultProgressStep wasn't updated and didn't render properly. This should have been caught by linting when this was being implemented. The linting should be fixed by packit#392
This was referenced Apr 7, 2024
lachmanfrantisek
pushed a commit
to Venefilyn/dashboard
that referenced
this pull request
Apr 8, 2024
Some dependencies to `useMemo` in ResultProgressStep wasn't updated and didn't render properly. This should have been caught by linting when this was being implemented. The linting should be fixed by packit#392
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
Some dependencies to `useMemo` in ResultProgressStep wasn't updated and didn't render properly. This should have been caught by linting when this was being implemented. The linting should be fixed by #392
ESLint wasn't configured correctly and wasn't run as it should. This enables it and also extends it with more rules to also cover TypeScript.
2c0eb3b to
a486775
Compare
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 53s |
a486775 to
07c37cb
Compare
Collaborator
Author
|
Current issues not fixed. But ready for review @lachmanfrantisek @lbarcziova yarn lint output |
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 44s |
lachmanfrantisek
approved these changes
May 20, 2024
lachmanfrantisek
left a comment
Member
There was a problem hiding this comment.
Don't understand much but thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESLint wasn't configured correctly and wasn't run as it should. This
enables it and also extends it with more rules to also cover TypeScript.
TODO:
packit/packit.dev.Fixes
Related to
Merge before/after
RELEASE NOTES BEGIN
Fix ESLint not working correct and align Prettier with pre-commit
RELEASE NOTES END