fix: memoize dependencies in ResultProgressStep#393
Merged
lachmanfrantisek merged 1 commit intoApr 8, 2024
Conversation
|
Preview: https://packit-dashboard-pr-393.surge.sh (deployed at Mon 08 Apr 2024, 14:12 UTC) |
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 51s |
lachmanfrantisek
approved these changes
Apr 8, 2024
Some dependencies to `useMemo` in ResultProgressStep wasn't updated and didn't render properly. This should have been caught by linting when this was being implemented. The linting should be fixed by packit#392
lachmanfrantisek
force-pushed
the
fix/progress-step-dependencies
branch
from
9e3ecf5 to
661a2d0
Compare
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 49s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some dependencies to
useMemoin ResultProgressStep wasn't updated anddidn't render properly. This should have been caught by linting when
this was being implemented. The linting should be fixed by #392
TODO:
packit/packit.dev.Fixes
Related to
Merge before/after
RELEASE NOTES BEGIN
Fix memoize dependencies in
ResultProgressStepRELEASE NOTES END