-
Notifications
You must be signed in to change notification settings - Fork 0
Dynamic payload analysis version with all basic feature implemented (max payloads, affordable configs, torque requirements, payload selection) #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rations of workspace
| # Documentation | ||
|
|
||
| This file contains the doucmentation for the user setup and testing anf also to server as a tutorials for the users. No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this deleted in this branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the documentation is the documentation branch, so for better separation of topics I deleted the other files
dynamic_payload_analysis_core/dynamic_payload_analysis_core/core.py
Outdated
Show resolved
Hide resolved
dynamic_payload_analysis_core/dynamic_payload_analysis_core/core.py
Outdated
Show resolved
Hide resolved
dynamic_payload_analysis_core/dynamic_payload_analysis_core/core.py
Outdated
Show resolved
Hide resolved
| from setuptools import find_packages, setup | ||
|
|
||
| package_name = 'dynamic_payload_analysis_core' | ||
|
|
||
| setup( | ||
| name=package_name, | ||
| version='0.0.0', | ||
| packages=find_packages(exclude=['test']), | ||
| data_files=[ | ||
| ('share/ament_index/resource_index/packages', | ||
| ['resource/' + package_name]), | ||
| ('share/' + package_name, ['package.xml']), | ||
| ], | ||
| install_requires=['setuptools'], | ||
| zip_safe=True, | ||
| maintainer='Enrico Moro', | ||
| maintainer_email='enrimoro003@gmail.com', | ||
| description='This package implements core functionalities for dynamic payload analysis in robotics, focusing on torque calculations and external force handling.', | ||
| license='Apache License 2.0', | ||
| tests_require=['pytest'], | ||
| entry_points={ | ||
| 'console_scripts': [ | ||
| ], | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this one
| @@ -1,23 +0,0 @@ | |||
| # Copyright 2015 Open Source Robotics Foundation, Inc. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are all the tests deleted?
| [develop] | ||
| script_dir=$base/lib/dynamic_payload_analysis_ros | ||
| [install] | ||
| install_scripts=$base/lib/dynamic_payload_analysis_ros |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
| from setuptools import find_packages, setup | ||
|
|
||
| package_name = 'dynamic_payload_analysis_ros' | ||
|
|
||
| setup( | ||
| name=package_name, | ||
| version='0.0.0', | ||
| packages=find_packages(exclude=['test']), | ||
| data_files=[ | ||
| ('share/ament_index/resource_index/packages', | ||
| ['resource/' + package_name]), | ||
| ('share/' + package_name, ['package.xml']), | ||
| ], | ||
| install_requires=['setuptools'], | ||
| zip_safe=True, | ||
| maintainer='Enrico Moro', | ||
| maintainer_email='enrimoro003@gmail.com', | ||
| description='This package provides graphics tools in Rviz for dynamic payload analysis in robotics with a focus on torque calculations and external force handling.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why?
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same goes for the tests here
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing
| <test_depend>python3-pytest</test_depend> | ||
|
|
||
| <depend>python3-numpy</depend> | ||
| <depend>urdfdom_py</depend> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <depend>urdfdom_py</depend> | |
| <depend>urdf_parser_py</depend> |
Isn't it this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but I found in google that the package that implements that library is urdfdom_py. See this : http://wiki.ros.org/urdfdom_py
Final version of dynamic payload analysis