Skip to content

Conversation

@enrico391
Copy link
Collaborator

Final version of dynamic payload analysis

enrico391 added 30 commits July 14, 2025 08:19
Comment on lines 1 to 3
# Documentation

This file contains the doucmentation for the user setup and testing anf also to server as a tutorials for the users. No newline at end of file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this deleted in this branch?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the documentation is the documentation branch, so for better separation of topics I deleted the other files

Comment on lines 1 to 25
from setuptools import find_packages, setup

package_name = 'dynamic_payload_analysis_core'

setup(
name=package_name,
version='0.0.0',
packages=find_packages(exclude=['test']),
data_files=[
('share/ament_index/resource_index/packages',
['resource/' + package_name]),
('share/' + package_name, ['package.xml']),
],
install_requires=['setuptools'],
zip_safe=True,
maintainer='Enrico Moro',
maintainer_email='enrimoro003@gmail.com',
description='This package implements core functionalities for dynamic payload analysis in robotics, focusing on torque calculations and external force handling.',
license='Apache License 2.0',
tests_require=['pytest'],
entry_points={
'console_scripts': [
],
},
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this one

@@ -1,23 +0,0 @@
# Copyright 2015 Open Source Robotics Foundation, Inc.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all the tests deleted?

Comment on lines 1 to 4
[develop]
script_dir=$base/lib/dynamic_payload_analysis_ros
[install]
install_scripts=$base/lib/dynamic_payload_analysis_ros
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Comment on lines 1 to 18
from setuptools import find_packages, setup

package_name = 'dynamic_payload_analysis_ros'

setup(
name=package_name,
version='0.0.0',
packages=find_packages(exclude=['test']),
data_files=[
('share/ament_index/resource_index/packages',
['resource/' + package_name]),
('share/' + package_name, ['package.xml']),
],
install_requires=['setuptools'],
zip_safe=True,
maintainer='Enrico Moro',
maintainer_email='enrimoro003@gmail.com',
description='This package provides graphics tools in Rviz for dynamic payload analysis in robotics with a focus on torque calculations and external force handling.',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Comment on lines 2 to 7
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes for the tests here

@enrico391 enrico391 changed the title Final version Dynamic payload analysis version with all basic feature implemented (max payloads, affordable configs, torque requirements, payload selection) Aug 14, 2025
Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing

<test_depend>python3-pytest</test_depend>

<depend>python3-numpy</depend>
<depend>urdfdom_py</depend>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<depend>urdfdom_py</depend>
<depend>urdf_parser_py</depend>

Isn't it this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but I found in google that the package that implements that library is urdfdom_py. See this : http://wiki.ros.org/urdfdom_py

@saikishor saikishor merged commit 4e96fa8 into master Aug 16, 2025
@saikishor saikishor deleted the talos_analysis branch August 16, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants