Use ActivityLifecycleCallbacks for start,stop,pause and resume events#71
Merged
palaima merged 2 commits intopalaima:devfrom Jan 29, 2017
Merged
Conversation
|
+1 |
spirosoik
reviewed
Nov 2, 2016
|
|
||
| @Override | ||
| public void onActivityPaused(Activity activity) { | ||
| if (mActivity == activity) { |
There was a problem hiding this comment.
may use .equals() instead for checking equality in objects?
Author
There was a problem hiding this comment.
Since the lifecycle callbacks and the debug drawer are installed for that particular instance of an Activity I think you would have to check if they are actually the same instance. So object equality is needed here
Author
There was a problem hiding this comment.
Also android.app.Activity itself does not override equals() itself the implementation from the Object class will be used which is return (this == obj);
There was a problem hiding this comment.
true story just also checked that equals is not be overrided by activity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.