-
Notifications
You must be signed in to change notification settings - Fork 124
Use ActivityLifecycleCallbacks for start,stop,pause and resume events #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
debugdrawer/src/main/java/io/palaima/debugdrawer/util/DebugDrawerLifecycleCallbacks.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| package io.palaima.debugdrawer.util; | ||
|
|
||
| import android.app.Activity; | ||
| import android.app.Application; | ||
| import android.os.Bundle; | ||
|
|
||
| import io.palaima.debugdrawer.DebugDrawer; | ||
|
|
||
| public class DebugDrawerLifecycleCallbacks implements Application.ActivityLifecycleCallbacks { | ||
| private Activity mActivity; | ||
| private DebugDrawer mDebugDrawer; | ||
|
|
||
| public DebugDrawerLifecycleCallbacks(Activity activity, DebugDrawer debugDrawer) { | ||
| mActivity = activity; | ||
| mDebugDrawer = debugDrawer; | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivityCreated(Activity activity, Bundle savedInstanceState) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void onActivityStarted(Activity activity) { | ||
| if (mActivity == activity) { | ||
| mDebugDrawer.onStart(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivityResumed(Activity activity) { | ||
| if (mActivity == activity) { | ||
| mDebugDrawer.onResume(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivityPaused(Activity activity) { | ||
| if (mActivity == activity) { | ||
| mDebugDrawer.onPause(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivityStopped(Activity activity) { | ||
| if (mActivity == activity) { | ||
| mDebugDrawer.onStop(); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivitySaveInstanceState(Activity activity, Bundle outState) { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void onActivityDestroyed(Activity activity) { | ||
| mActivity.getApplication().unregisterActivityLifecycleCallbacks(this); | ||
| mActivity = null; | ||
| mDebugDrawer = null; | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may use
.equals()instead for checking equality in objects?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the lifecycle callbacks and the debug drawer are installed for that particular instance of an Activity I think you would have to check if they are actually the same instance. So object equality is needed here
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also
android.app.Activityitself does not overrideequals()itself the implementation from theObjectclass will be used which isreturn (this == obj);There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true story just also checked that
equalsis not be overrided by activity