highlight jsdoc optional param and optional param with default value#224
Closed
ryanoasis wants to merge 4 commits intopangloss:developfrom
ryanoasis:master
Closed
highlight jsdoc optional param and optional param with default value#224ryanoasis wants to merge 4 commits intopangloss:developfrom ryanoasis:master
ryanoasis wants to merge 4 commits intopangloss:developfrom
ryanoasis:master
Conversation
Contributor
ryanoasis
commented
Dec 9, 2014

Update Master
Merging CONTRIBUTING.md into Master
Update Master
Collaborator
|
This looks good, but the branch has some weird merge commits that worked their way in. Probably the easiest way to to fix would be to create a branch that is all up to date with this repo's develop. Assuming you added this repo as a new remote ( Then simply cherrypick that single commit onto it: Then push that you branch to your repo: and then submit a PR using that new branch. |
Contributor
Author
|
@amadeus yep I did notice that. thanks. i'll do that. |
Collaborator
|
Superseded by #225 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.