Immediately invalidate written files in write_digest (Cherry-pick of #19903) - #19948
Merged
Conversation
This ensures that files changed by `write_digest` are immediately flagged as changed/invalidated, for any follow-on processing, by invalidating them in the graph as part of the write. Previously, `write_digest` just changed files directly, and we were relying on file-change notifications to make the graph aware of those changes, but this is racy: a command like `pants fmt lint ::` will write any formatting changes as part of `fmt` and immediately run `lint`, hopefully on those files... if the `lint` call happens soon enough, it'll run before the graph is aware of the changed files, and give incorrect results. This fixes #19897
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that files changed by
write_digestare immediately flagged as changed/invalidated, for any follow-on processing, by invalidating them in the graph as part of the write.Previously,
write_digestjust changed files directly, and we were relying on file-change notifications to make the graph aware of those changes, but this is racy: a command likepants fmt lint ::will write any formatting changes as part offmtand immediately runlint, hopefully on those files... if thelintcall happens soon enough, it'll run before the graph is aware of the changed files, and give incorrect results.This fixes #19897