Refine Rust workspace members for recently added crates - #20117
Merged
Conversation
huonw
force-pushed
the
huonw/remote-providers-default-member
branch
from
October 29, 2023 09:52
5eee00b to
f23059a
Compare
huonw
commented
Oct 29, 2023
| "fs/fs_util", | ||
| "fs/store", | ||
| "graph", | ||
| "grpc_util", |
Contributor
Author
There was a problem hiding this comment.
Potentially this and protos were intentionally omitted? (A quick skim of the long discussion on #11307 that introduced them didn't make this obvious.)
huonw
marked this pull request as ready for review
October 29, 2023 09:55
thejcannon
approved these changes
Oct 31, 2023
tdyas
approved these changes
Nov 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a been a few new crates added recently (#18854, #19958), but we didn't update
[workspace].membersand[workspace].default-membersinsrc/rust/engine/Cargo.tomlto match. In addition, the olderprotosandgrpc_utilweren't listed. This syncs up the lists.The lists of
membersanddefault-membersnow exactly matches, except forfs/brfsas commented. They also match theCargo.tomls that exist on disk.