Concurrent pantsd: Swap uncacheability for run-scoped results - #23616
Open
tobni wants to merge 2 commits into
Open
Concurrent pantsd: Swap uncacheability for run-scoped results#23616tobni wants to merge 2 commits into
tobni wants to merge 2 commits into
Conversation
A Run which attaches to another Run's in-flight attempt cannot consume its run-scoped result, so it re-enters to compute its own.
tobni
added
category:internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeResult holds the producing RunId in place of an "uncacheable" bool. A Run that attaches to an in-flight attempt started by another Run re-enters get_node_result instead of taking that attempt's result.
Nothing can observe another Run's attempt under the pantsd concurrency lock, so this change is behaviour-preserving work.
See https://docs.google.com/document/d/1XEO55efGI8x91wGiVjmlFpUORJeQpZ2xF4zQoSE4TuY/edit?tab=t.0#heading=h.apz3211m77eg for design intent.