Alyssa/add wire support - #712
Closed
ericzundel wants to merge 12 commits into
Closed
Conversation
Member
Author
There was a problem hiding this comment.
You can remove this line
alyssa
force-pushed
the
alyssa/add-wire-support
branch
7 times, most recently
from
October 23, 2014 15:35
267b3fa to
494da8e
Compare
This logic is used by both protobuf_gen and wire_gen. Put this logic into a module function in protobuf_gen so that it can be re-used.
tests/python/pants_test/backend/codegen/tasks dir.
alyssa
force-pushed
the
alyssa/add-wire-support
branch
from
October 30, 2014 16:07
17a3ade to
5c47341
Compare
alyssa
force-pushed
the
alyssa/add-wire-support
branch
from
October 30, 2014 16:47
5c47341 to
951ca5d
Compare
Member
Author
There was a problem hiding this comment.
this looks > 100chars wide
alyssa
force-pushed
the
alyssa/add-wire-support
branch
from
October 31, 2014 14:52
3140d35 to
d337a47
Compare
Member
Author
|
this has now landed under a different branch name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.