Extract out parsing proto file logic from ProtobufGen - #755
Closed
alyssa wants to merge 3 commits into
Closed
Conversation
alyssa
changed the title
alyssa
force-pushed
the
alyssa/refactor+protobuf+gen
branch
from
October 31, 2014 14:48
0bcf53c to
0408d4f
Compare
Member
There was a problem hiding this comment.
shouldn't we also pass the service list into this method?
Author
There was a problem hiding this comment.
We don't have to. The protobuf compiler always generates java classe for services. The wire compiler optionally does this, thus we'll have to pass in service_writer when calling this in wire_gen
alyssa
force-pushed
the
alyssa/refactor+protobuf+gen
branch
from
October 31, 2014 18:01
0408d4f to
1965550
Compare
Member
There was a problem hiding this comment.
- The name 'type' shadows a builtin
- Let's not use '%' style formatting, its going away in Python 3
- Now that I see it this way, there is a shorthand that might make it look better.
classnames = set(['{name}OrBuilder'.format(name=t) for t in protobuf_parse.messages])
classnames = classnames.union(protobuf_parse.messages)
Author
There was a problem hiding this comment.
yay for list comprehension, made the change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.