File new behavior #156
Merged
File new behavior #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spatializes
force-pushed
the
fileNewBehavior
branch
from
f2a3608 to
bb106b5
Compare
plugins/editor/key-extension.js
Outdated
Contributor
|
Excellent descriptions @DrQuinn, thank you! Looking forward to trying out these features. |
src/stores/file.js
Outdated
Contributor
There was a problem hiding this comment.
should be defined above the relative requires
Contributor
|
reassigned to @2fast2fourier to review since I made changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Changes logic for new files and saving files. New files are now created as blank pages and named with untitled# (with # being the next number after the highest numbered untitled file in your working directory).
Unsaved files will Save As, prompting a Save As overlay with Untitled# showing in the filename field.
Saved files will simply save to their current name.
Ctrl-S and the save button should work for both of these circumstances.
Where should the reviewer start?
npm install (to get Frylord updates)
npm run build
How should this be manually tested?
Open ChromeIDE, create a new file (with the New File button and with Ctrl-N). Write some text into the file. You shouldn't see any errors in the Dev Tools console. Save (using the Save button or Ctrl-S), should open the Save As overlay. Untitled# (#, based on file directory) should show in the filename input. Save the untitled file. Create and save a few more untitled files. Be sure the numbers are incrementing properly. Click the Save button or press Ctrl-S on a file that is already saved. It should simply save without prompting the Save As dialog.
Create a new file. Try to click away to a different file in your directory. ChromeIDE should ask you to Save As.
Try different scenarios with opening new files, saving, and navigating to be certain everything is working as expected.
What are the relevant tickets?
Closes #107