This repository was archived by the owner on Nov 15, 2023. It is now read-only.
pallet-beefy-mmr: fix when using custom hashing#14273
Merged
acatangiu merged 1 commit intoparitytech:masterfrom May 31, 2023
Merged
pallet-beefy-mmr: fix when using custom hashing#14273acatangiu merged 1 commit intoparitytech:masterfrom
acatangiu merged 1 commit intoparitytech:masterfrom
Conversation
`Hash` is no longer part of `pallet_mmr::Config`, but this code would still build because it assumes we're referring to underlying `<pallet_mmr::Config as frame_system::Config>::Hash` which is not what we want when using different hashing between `frame_system` and `pallet_mmr`. Disambiguate by using correct `pallet_mmr::Config::Hashing` type. Signed-off-by: acatangiu <adrian@parity.io>
acatangiu
added
A0-please_review
serban300
approved these changes
May 31, 2023
svyatonik
approved these changes
May 31, 2023
bkchr
approved these changes
May 31, 2023
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
Why wasn't this detected by the CI? 🤔
Contributor
Author
Because it's only deployed in On Millau (bridges test chain) it complained loudly. |
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
`Hash` is no longer part of `pallet_mmr::Config`, but this code would still build because it assumes we're referring to underlying `<pallet_mmr::Config as frame_system::Config>::Hash` which is not what we want when using different hashing between `frame_system` and `pallet_mmr`. Disambiguate by using correct `pallet_mmr::Config::Hashing` type. Signed-off-by: acatangiu <adrian@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix on top of #14214:
Hashis no longer part ofpallet_mmr::Config, but this code would still build because it assumes we're referring to underlying<pallet_mmr::Config as frame_system::Config>::Hashwhich is not what we want when using different hashing betweenframe_systemandpallet_mmr.Disambiguate by using correct/custom
pallet_mmr::Config::Hashingtype.