Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@gilescope
Copy link
Contributor

There's one place where we are intentionally doing this so have put an exclude in for that.

Same as paritytech/cumulus#2721

@gilescope gilescope added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Jun 9, 2023
@gilescope gilescope requested review from a team June 9, 2023 11:20
@gilescope
Copy link
Contributor Author

Hmm, #[allow(hidden_glob_reexports)] is not yet understood by the CI's version of rust.
For now let's remove all but this one warning.

@bkchr bkchr merged commit 5861423 into master Jun 13, 2023
@bkchr bkchr deleted the giles-remove-warnings branch June 13, 2023 07:36
nathanwhit pushed a commit to nathanwhit/substrate that referenced this pull request Jul 19, 2023
* fix new warning

* Too soon

* Explicitly import
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants