This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Don't set HEAP_PAGES in BasicExternalities#3244
Merged
Conversation
bkchr
added
A0-please_review
jacogr
approved these changes
Jul 30, 2019
Contributor
jacogr
left a comment
jacogr
left a comment
There was a problem hiding this comment.
lgtm from an actual verification testing perspective. Tested it with a proposals of 907K and 1MB - it solves the issues we've been having and these do go through.
gavofyork
approved these changes
Jul 30, 2019
gavofyork
added
A7-looksgoodtestsfail
and removed
A0-please_review
Closed
gui1117
reviewed
Jul 30, 2019
Contributor
gui1117
left a comment
gui1117
left a comment
There was a problem hiding this comment.
Also TestExternalities does add this HEAP_PAGE key, I'm not sure that's necessary either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3174 (comment)