This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
bkchr
added
A0-please_review
bkchr
requested review from
NikVolf,
andresilva,
sorpaas and
tomusdrw
as code owners
ordian
approved these changes
Feb 13, 2021
drahnr
reviewed
Feb 14, 2021
| inherent_data | ||
| )) | ||
| }) | ||
| }).map_err(|e| Error::Application(Box::new(e))) |
Contributor
There was a problem hiding this comment.
Nit: I would prefer adding another error variant, so ::Application can cease to exist eventually, and be replaced with more detailed variants.
bkchr
added a commit
to paritytech/polkadot
that referenced
this pull request
Feb 14, 2021
Member
Author
|
bot merge |
|
Trying merge. |
ghost
merged commit
athei
pushed a commit
that referenced
this pull request
Feb 15, 2021
* Ahh * Work work work * Fix all the compilation errors * Fix test * More fixes...
bkchr
added a commit
to paritytech/polkadot
that referenced
this pull request
Feb 15, 2021
* Polkadot companion for 8114 paritytech/substrate#8114 * "Update Substrate" Co-authored-by: parity-processbot <>
KalitaAlexey
pushed a commit
to KalitaAlexey/substrate
that referenced
this pull request
Jul 9, 2021
* Ahh * Work work work * Fix all the compilation errors * Fix test * More fixes...
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr simplifies the runtime api error handling by introducing an error type for the runtime api.
polkadot companion: paritytech/polkadot#2437