feat: Add system_chainType to legacy rpcs#2116
Conversation
testing/integration-tests/src/full_client/client/legacy_rpcs.rs
Outdated
Show resolved
Hide resolved
jsdw
left a comment
jsdw
left a comment
There was a problem hiding this comment.
Looks great, thank you! Just a very minor suggestion!
If you need this sooner rather than later then we can do a patch release of just this crate since it doesn't break anything. Let me know either way!
|
Looks like this job is causing some issues, but not sure why. |
Let me look into this. It looks like the job that builds the nightly binaries failed at some point or something to that effect! |
|
Fingers crossed this is all good again now, so I'll merge this once it's passing and if you would like it in a release then I would probably add a separate PR which bumps only the subxt-rpcs crate patch version and release that without a full changelog writeup etc (which can come when we do a full subxt release at some point). |
2 participants
Adds a missing legacy rpc method.
Please let me know if there is anything else i need to add.