build(deps): update frame-decode to 0.18.0 - #2268
Draft
pgherveou wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frame-decoderequirement from 0.17.1 to 0.18.0.VerifySignatureextension implementation as the owner of the authorization boundary; no duplicate payload logic is added to Subxt.Why
Subxt's
VerifySignatureimplementation already clears explicit and implicit implications that precedeVerifyMultiSignature. With frame-decode 0.17, that boundary also removed the call from the signer payload and the transaction-extension version was omitted. frame-decode 0.18 keeps(transaction_extension_version, call)as the immutable base implication and clears only preceding extension implications.Dependency and rollout
Depends on paritytech/frame-decode#104.
This PR must remain draft until that PR is merged and
frame-decode 0.18.0is published. After publication, the Subxt lockfile should be refreshed in a follow-up commit and normal CI can resolve the crate from crates.io.Validation
Validated against the local frame-decode PR checkout using Cargo's command-line patch configuration:
cargo check -p subxtcargo check -p subxt --no-default-features --features webcreateTransactionexample: both V4 and V5 construction passed; V5 produced a General extrinsic with inner prefix0x45Downstream integration
paritytech/truapi#333 consumes this Subxt branch and the frame-decode change through immutable Git revisions. Its complete server suite, generated V4/V5 example checks, and focused CLI V5 transaction check pass.
Current Subxt CI failures are expected dependency-resolution failures: crates.io reports
frame-decode 0.18.0as yanked. The frame-decode release version must be moved to an available version, then this dependency requirement and lockfile must be updated in follow-up commits.