Open Source ParsePush (っ˘▽˘)っ ☁️ #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM! 🚢 |
ParsePush/build.gradle
Outdated
There was a problem hiding this comment.
If you hardcode the version number, I do not think you still need gradle.properties.
The two versions are not match, which one is the right one?
Contributor
Author
There was a problem hiding this comment.
You're totally right. Which come to these questions:
On Android SDK, which one do we update? And which one is the source of truth?
There was a problem hiding this comment.
We delete gradle.properties and use the version number in build.gradle. The reason is different repos have different versions and release cycles, it does not make sense to have a unify version number.
There was a problem hiding this comment.
If we only need the jar in release, maybe add
if (name.equals(BuilderConstants.RELEASE)) {
artifacts.add('archives', jarTask);
}
Closed
hallucinogen
force-pushed
the
gogo.add-parse-push
branch
3 times, most recently
from
645c7d1 to
bb6d040
Compare
hallucinogen
force-pushed
the
gogo.add-parse-push
branch
from
bb6d040 to
5e890b9
Compare
|
LGTM |
hallucinogen
added a commit
that referenced
this pull request
Nov 16, 2015
Open Source ParsePush (っ˘▽˘)っ ☁️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the closed-source
ParsePushrepo to .NET SDK repo.Test Plan:
./gradlew jarRelease@grantland, please kindly review all the
gradlewrelated stuff.CC: @richardjrossiii, @stanleyw, @nlutsenko, @wangmengyan95
👯
Fixes #74.