Merged
Conversation
Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com>
castastrophe
approved these changes
Jan 25, 2021
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
Lemons Grated Taste Minty?
castastrophe
added
ready: design review
blocked
* feat: adding icon color variable * feat: fixed variable names on readme, corrected pfe-icon--Color * feat: tie text--muted color variable to icon--Color
heyMP
removed
blocked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pfe-clipboard
pfe-clipboard allows developers to include button to "copy url to clipboard" that can be placed web pages and handle the entire process of displaying a button that, when clicked, will copy the url to the users system clipboard.
Related Issues
Preview
Link(s) to demo page(s) where this element can be viewed:
Testing instructions
?testing123https://deploy-preview-1235--happy-galileo-ea79c4.netlify.app/elements/pfe-clipboard/demo/?testing123Browser requirements
Your component should work in all of the following environments:
Ready-for-merge Checklist
Check off items as they are completed. Feel free to delete items if they are not applicable.
Merging
Please squash when merging and ensure your commit message uses conventional commit formatting.
Be sure to share your updates with the patternfly-elements-contribute@redhat.com mailing list!