US267056-pfe-clipboard: Icon Color Custom Property#1301
Merged
castastrophe merged 3 commits intoUS267056-pfe-clipboardfrom Jan 25, 2021
Merged
US267056-pfe-clipboard: Icon Color Custom Property#1301castastrophe merged 3 commits intoUS267056-pfe-clipboardfrom
castastrophe merged 3 commits intoUS267056-pfe-clipboardfrom
Conversation
github-actions
Bot
added
demo
castastrophe
suggested changes
Jan 25, 2021
Contributor
castastrophe
left a comment
castastrophe
left a comment
There was a problem hiding this comment.
A couple small updates, otherwise looks great!
castastrophe
approved these changes
Jan 25, 2021
castastrophe
added a commit
that referenced
this pull request
Jan 25, 2021
* feat: added pfe-clipboard element, adding slots and some styling * add an extend for host selector * add a11y attributes to treat pfe-clipboard as button * initial copy to clipboard function * added new Clipboard API with fallbacks * added demos * added icon-hidden boolean * add height auto to better account for other icons * added title to demo * adding pfe-toast as default notification option. * added template override to pfe-toast. * removed dynamic imports for now. Added template fallbacks for notifications * added notification text to slot schema * added demos * removed dynamic imports for now. Added template fallbacks for notifications * chore: added todo * added demo for custom icon, fixed icon variables * taking a stab at adding background vars * make default text into the default slot * added keyboard event listeners * move button to internal container * converted copyURLToClipboard to promise based * update docs * fixing svg widths in safari * added position fixed for toast * ie11 hacks to behave like a button. * added lighter weight font * added space to button input for a11y * chore: remove log * added a copied text slot and new state * fixed the hover and focused states to have outline instead of background * changed padding to 6 x 16px to match styleguide * adding aria alert based on https://www.w3.org/TR/wai-aria-practices-1.1/examples/alert/alert.html * corrected ie11 issues with styling slots * updated demo to not emphasis notifications * feat: remove notifications 🔪 * chore: comments and removing toast in scss * initial tests * check for slot content * added check for hidden-icon * bump version * combined h2 styles in demo https://github.com/patternfly/patternfly-elements/pull/1235/files/c0753744d52158f78279774374d579b2e8bb4497#r548153171 * Added pfe-icon for the custom icon examples. https://github.com/patternfly/patternfly-elements/pull/1235/files/c0753744d52158f78279774374d579b2e8bb4497#r548154117 * add custom storybook defaults https://github.com/patternfly/patternfly-elements/pull/1235/files/c0753744d52158f78279774374d579b2e8bb4497#r548155043 * always use the config default content. * Updating version https://github.com/patternfly/patternfly-elements/pull/1235/files/c0753744d52158f78279774374d579b2e8bb4497#r548156029 * added pfelement and pfe-sass correct version https://github.com/patternfly/patternfly-elements/pull/1235/files/c0753744d52158f78279774374d579b2e8bb4497#r548155984 * removed pfe-clipboard__container from shadowRoot https://github.com/patternfly/patternfly-elements/pull/1235/files/c0753744d52158f78279774374d579b2e8bb4497#r548157632 * remove unused css. Fixed :host selector for hover,focus * remove reference to old named slot * Added README! 📙 * reformatted slots docs * updated readme * Revert "updated readme" This reverts commit 0f9aa82. * add dynamic rendering for icon-hidden attribute * reverting pfe-card erronious changes * reverting pfe-card erronious changes * make title for icon hidden attribute more expressive * removed unused element references * removed unused element references * adding tab index and role button to all of the demos to encourage progressive enhancement * change property to no-icon from icon-hidden. Also added a _rendered state to the base class. * adding transposing slots * updated transpose slots to be more declarative * moving to test fixtures * added css variable for success color * test for slots * trying getelementstyle test * added temp fix for get computed style test * added copied event test * added transpose test * added check for aria roles * Bring in storybook patch from master * Update storybook utilities to support empty custom component * adding todo to move transposeSlot to use mutation observer * chore: Removing component specific changelog https://github.com/patternfly/patternfly-elements/pull/1235\#discussion_r55674077�5 * chore: Removing discovery doc https://github.com/patternfly/patternfly-elements/pull/1235\#discussion_r556740943 * fix: incorrect success color being tested * fix: removed prefixed slot names * chore: improve description of public copyURLToClipboard function * chore: removing branch leak change to storybook * chore: removing old references to pfe-toast * chore: removing boilerplate sass docs * feat: using icon-size var for icon width * chore: removing unneaded attribute name on property definition * feat: Us267056 pfe clipboard copied duration (#1289) * feat: added copiedTimeout property. Made copied state setTimeout dynamic. * feat: change name to copied-duration. updated docs * test: added new test for copiedDuration * chore: removing unneaded attribute name on property definition Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: trigger netlify * chore: trigger visual regression build * feat: added vars to control padding on host and margin on icon (#1290) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: moving getTemplate to a separate branch * Update elements/pfe-clipboard/demo/pfe-clipboard.story.js Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com> * Update elements/pfe-clipboard/src/pfe-clipboard.js Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com> * chore: updated copyURLToClipboard api docs * chore: remove commented out code * feat: cleaning up color variable implementation * feat: remove isInteger to support IE11 * feat: adding vue and react tests 📋 * feat: adding vrt baseline for pfe-clipboard * fix: fixed IE11 copied state change: * feat: removing default slot * feat: added typography to demo * feat: updated vrt baseline snapshot * feat: added new variable hooks to Readme * feat: added screenshot to elements page listing * chore: stubbed out changelog addition for pfe-clipboard * chore: added engine and browserlist to package.json * US267056-pfe-clipboard: Icon Color Custom Property (#1301) * feat: adding icon color variable * feat: fixed variable names on readme, corrected pfe-icon--Color * feat: tie text--muted color variable to icon--Color * fix: fixed icon fallback test * fix: updated vrt screenshots Co-authored-by: [ Cassondra ] <carobert@redhat.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: [ Cassondra ] <castastrophe@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design review suggested that we ensure the pfe-icons default to the same color as the fallback svg contained in the "icon" slot.
I added a new custom property
--pfe-clipboard--icon--Colorthat affects pfe-icon and the fallback svg.