Skip to content

pfe-accordion | resolves accessibility issue 444 #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisdo1 merged 9 commits into from
Sep 5, 2019
Merged

pfe-accordion | resolves accessibility issue 444 #447

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c35dd8e
- Move border bottom from button to panel, so that it moves with the …
starryeyez024 Jun 26, 2019
42fec0c
change link underline color on focus
starryeyez024 Jun 26, 2019
f5ced0f
Merge branch 'master' into issue-444/accordion-focus
kylebuch8 Aug 16, 2019
eaeafc3
Merge branch 'master' into issue-444/accordion-focus
kylebuch8 Aug 19, 2019
632327b
issue-444 set underline color for focus states on dark to white
chrisdo1 Aug 28, 2019
3ecd7ca
issue-444
chrisdo1 Aug 28, 2019
bae3802
issue-444: reverted dark theme border left hover color
chrisdo1 Aug 29, 2019
c8d13d2
Merge branch 'master' into issue-444/accordion-focus
chrisdo1 Sep 3, 2019
12b8736
issue-444 removed TextDecorationColor from accordion header mixins.
chrisdo1 Sep 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions elements/pfe-sass/mixins/_mixins.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ $pfe-expand_chevron--placement: #{$pfe-expand_button--LineHeight / 2 - $pfe
outline: none;
z-index: 2;
text-decoration: underline;
text-decoration-color: #{pfe-color(surface--border--darker)};
}

&::-moz-focus-inner {
Expand All @@ -269,6 +268,7 @@ $pfe-expand_chevron--placement: #{$pfe-expand_button--LineHeight / 2 - $pfe

@mixin pfe-trigger-button-last($theme: light) {
border-bottom: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border)};
border-top: 0;
// @TODO Support differences based on theme
}

Expand Down Expand Up @@ -305,8 +305,8 @@ $pfe-expand_chevron--placement: #{$pfe-expand_button--LineHeight / 2 - $pfe
@if $theme == dark {
--pfe-#{$component-name}--main: #{pfe-color(surface--darker)};
--pfe-#{$component-name}--aux: #{pfe-color(surface--darkest--text)};
--pfe-#{$component-name}--BorderLeft: #{pfe-var(surface--border-width--heavy)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border-darkest)};
--pfe-#{$component-name}--BorderRight: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border-darkest)};
--pfe-#{$component-name}--BorderLeft: #{pfe-var(surface--border-width--heavy)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border)};
--pfe-#{$component-name}--BorderRight: #{pfe-var(surface--border-width)} #{pfe-var(surface--border-style)} #{pfe-color(surface--border)};

--pfe-#{$component-name}--BorderLeftColor--focus: #{pfe-color(surface--lightest)};
}
Expand Down Expand Up @@ -377,11 +377,13 @@ $pfe-expand_chevron--placement: #{$pfe-expand_button--LineHeight / 2 - $pfe
overflow: hidden;
will-change: height;
border-color: transparent;
opacity: 0;
}

@mixin pfe-accordion-panel-expanded {
display: block;
position: relative;
opacity: 1;
}

@mixin pfe-accordion-panel-expanded-style($theme: light) {
Expand All @@ -390,8 +392,8 @@ $pfe-expand_chevron--placement: #{$pfe-expand_button--LineHeight / 2 - $pfe
@if $theme == dark {
box-shadow: none;
background-color: #{pfe-color(surface--darker)};
border-left-color: #{pfe-color(surface--darkest--text)};
border-right-color: #{pfe-color(surface--darkest--text)};
border-left-color: #{pfe-color(surface--border)};
border-right-color: #{pfe-color(surface--border)};
}
@else {
box-shadow: 0 5px #{pfe-var(surface--border-width--heavy)} rgba(140, 140, 140, 0.35);
Expand All @@ -412,4 +414,4 @@ $pfe-expand_chevron--placement: #{$pfe-expand_button--LineHeight / 2 - $pfe
@else {
padding: 0 #{$pfe-expand_button--padding--wide} #{$pfe-expand_button--padding} #{$pfe-expand_chevron--padding};
}
}
}