pfe-accordion | resolves accessibility issue 444#447
Merged
Conversation
…panel while expanding/collapsing - change focus underline color to ui-link for visibility
Member
Author
|
@kylebuch8 how do i get a netlify link to appear here? |
starryeyez024
changed the title
Contributor
|
@starryeyez024 The preview is now available. I just told this branch to merge master in. |
Contributor
|
@starryeyez024 I wonder if we should set the
|
Member
Author
@chrisdo1 makes sense to me! |
* also addressed issue with border colors on expanded accordions on dark backgrounds (see issue 514).
Member
Author
|
@chrisdo1 your code LGTM; I think you can approve and merge since I opened the MR 👍 |
Member
Author
|
@chrisdo1 Lester's Grandpa Tells Myths |
chrisdo1
approved these changes
Sep 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Accordion focus color could be improved for accessibility #444"