Skip to content

fix(InfrastructureIcons): replaced with RH brand icons part 4#12504

Merged
kmcfaul merged 2 commits into
patternfly:mainfrom
thatblindgeye:iss12399_part4
Jul 8, 2026
Merged

fix(InfrastructureIcons): replaced with RH brand icons part 4#12504
kmcfaul merged 2 commits into
patternfly:mainfrom
thatblindgeye:iss12399_part4

Conversation

@thatblindgeye

@thatblindgeye thatblindgeye commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What: Towards #12399

Covers FileUpload, Download, Upload, and Clone icons

Additional issues:

Summary by CodeRabbit

  • Style
    • Refreshed icons across the component library and demos to use PatternFly React UI icon variants for upload, download, document, and copy actions (including CodeEditor, Button, FileUpload, MultipleFileUpload, Toolbar, and Table).
  • Documentation
    • Updated related example documentation and demo markup to match the new icon usage.
    • Minor formatting adjustments were made to ensure embedded example blocks render cleanly.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 35d7a274-a687-469d-8ad6-8c2f0dfa4417

📥 Commits

Reviewing files that changed from the base of the PR and between 305c1e9 and 328f97c.

⛔ Files ignored due to path filters (1)
  • packages/react-code-editor/src/components/CodeEditor/__test__/__snapshots__/CodeEditor.test.tsx.snap is excluded by !**/*.snap
📒 Files selected for processing (19)
  • packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
  • packages/react-core/src/components/Button/examples/Button.md
  • packages/react-core/src/components/Button/examples/ButtonCircle.tsx
  • packages/react-core/src/components/Button/examples/ButtonProgress.tsx
  • packages/react-core/src/components/FileUpload/examples/FileUpload.md
  • packages/react-core/src/components/FileUpload/examples/FileUploadCustomPreview.tsx
  • packages/react-core/src/components/MultipleFileUpload/examples/MultipleFileUpload.md
  • packages/react-core/src/components/MultipleFileUpload/examples/MultipleFileUploadBasic.tsx
  • packages/react-core/src/components/Toolbar/examples/Toolbar.md
  • packages/react-core/src/components/Toolbar/examples/ToolbarCustomLabelGroupContent.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarGroups.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx
  • packages/react-core/src/demos/MultipleFileUploadDemos.md
  • packages/react-core/src/demos/Toolbar.md
  • packages/react-core/src/demos/examples/MultipleFileUpload/MultipleFileUploadRejectedFile.tsx
  • packages/react-core/src/demos/examples/Toolbar/ConsoleLogViewerToolbar.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx
  • packages/react-table/src/demos/Table.md
  • packages/react-table/src/demos/examples/TableSortableResponsive.tsx
✅ Files skipped from review due to trivial changes (16)
  • packages/react-core/src/demos/MultipleFileUploadDemos.md
  • packages/react-core/src/demos/examples/MultipleFileUpload/MultipleFileUploadRejectedFile.tsx
  • packages/react-core/src/demos/Toolbar.md
  • packages/react-table/src/demos/Table.md
  • packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarGroups.tsx
  • packages/react-core/src/components/MultipleFileUpload/examples/MultipleFileUpload.md
  • packages/react-core/src/components/FileUpload/examples/FileUploadCustomPreview.tsx
  • packages/react-core/src/components/Toolbar/examples/ToolbarCustomLabelGroupContent.tsx
  • packages/react-core/src/components/Button/examples/ButtonProgress.tsx
  • packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx
  • packages/react-core/src/demos/examples/Toolbar/ConsoleLogViewerToolbar.tsx
  • packages/react-core/src/components/Button/examples/ButtonCircle.tsx
  • packages/react-core/src/components/MultipleFileUpload/examples/MultipleFileUploadBasic.tsx
  • packages/react-core/src/components/FileUpload/examples/FileUpload.md
  • packages/react-core/src/components/Toolbar/examples/Toolbar.md
🚧 Files skipped from review as they are similar to previous changes (3)
  • packages/react-core/src/components/Button/examples/Button.md
  • packages/react-core/src/components/Toolbar/examples/ToolbarWithFilters.tsx
  • packages/react-table/src/demos/examples/TableSortableResponsive.tsx

Walkthrough

This PR updates editor, component example, and demo icons to RH UI variants for upload, download, document, and copy actions, and adjusts FileUpload markdown example spacing around embedded code blocks.

Changes

Icon refresh across components, examples, and demos

Layer / File(s) Summary
Upload and download icon replacements
packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx, packages/react-core/src/components/Button/examples/*, packages/react-core/src/components/MultipleFileUpload/examples/*, packages/react-core/src/demos/MultipleFileUploadDemos.md, packages/react-core/src/demos/examples/MultipleFileUpload/*, packages/react-core/src/demos/Toolbar.md, packages/react-core/src/demos/examples/Toolbar/*
Upload and download actions now import and render RhUiUploadIcon or RhUiDownloadIcon in the editor, examples, and demos.
File upload preview and markdown cleanup
packages/react-core/src/components/FileUpload/examples/FileUpload.md, packages/react-core/src/components/FileUpload/examples/FileUploadCustomPreview.tsx
FileUpload examples switch to RhUiDocumentFillIcon, and the markdown example sections adjust code-fence and spacing lines around embedded example blocks.
Copy icon replacements in toolbar and table examples
packages/react-core/src/components/Toolbar/examples/*, packages/react-integration/demo-app-ts/src/components/demos/ToolbarDemo/ToolbarDemo.tsx, packages/react-table/src/demos/Table.md, packages/react-table/src/demos/examples/TableSortableResponsive.tsx
Toolbar, integration, and table examples replace clone icons with RhUiCopyFillIcon in imports and button icon props.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

Suggested labels: Needs design review

Suggested reviewers: kmcfaul, nicolethoen

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the PR’s main change: replacing infrastructure-related icons with RH brand icons in part 4.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Tools execution failed with the following error:

Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@patternfly-build

patternfly-build commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

@kmcfaul kmcfaul merged commit 4cc476a into patternfly:main Jul 8, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants