Skip to content

fix(readme): update broken Slack link#12547

Open
Axel-DaMage wants to merge 1 commit into
patternfly:mainfrom
Axel-DaMage:fix/broken-slack-link
Open

fix(readme): update broken Slack link#12547
Axel-DaMage wants to merge 1 commit into
patternfly:mainfrom
Axel-DaMage:fix/broken-slack-link

Conversation

@Axel-DaMage

@Axel-DaMage Axel-DaMage commented Jul 9, 2026

Copy link
Copy Markdown

What: Closes #12546, replaced https://slack.patternfly.org with https://patternfly.slack.com
in the README, matching the fix applied in patternfly-org#3364.

Additional issues: patternfly-org#3364 (previous fix in the docs site)

Summary by CodeRabbit

  • Documentation
    • Updated the Community Slack link in the README to the new workspace URL.

The slack.patternfly.org URL returns a 404. Replaced with
patternfly.slack.com, matching the fix in patternfly-org#3364.
Copilot AI review requested due to automatic review settings July 9, 2026 02:35

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

Updates the README Slack link and adds explicit aria-haspopup="listbox" handling to MenuToggle plus its Select-based example usages.

Changes

README Link Update

Layer / File(s) Summary
Update Slack URL in README
README.md
Changes the Community section Slack link from the old URL to https://patternfly.slack.com.

MenuToggle listbox semantics

Layer / File(s) Summary
Add aria-haspopup support
packages/react-core/src/components/MenuToggle/MenuToggle.tsx
Extends MenuToggleProps with aria-haspopup, sets a default value, and forwards it to rendered buttons in the typeahead, split-button, and default paths.
Set listbox popup on Select toggles
packages/react-core/src/components/Form/examples/FormState.tsx, packages/react-core/src/components/LoginPage/examples/LoginPageLanguageSelect.tsx, packages/react-core/src/components/Select/examples/*, packages/react-core/src/components/Toolbar/examples/*, packages/react-core/src/components/Tooltip/examples/TooltipOptions.tsx
Updates Select-based toggle renderers to pass aria-haspopup="listbox" on the underlying MenuToggle elements.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: nicolethoen, thatblindgeye

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR also adds aria-haspopup and MenuToggle API changes across many Select/Toolbar examples, which are unrelated to the README fix. Remove the accessibility/MenuToggle changes or split them into a separate PR focused on that behavior.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The README link is updated from the broken Slack URL to patternfly.slack.com, satisfying the linked issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing the README’s broken Slack link.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Axel-DaMage Axel-DaMage force-pushed the fix/broken-slack-link branch from e888350 to 8619220 Compare July 9, 2026 17:48
@Axel-DaMage

Copy link
Copy Markdown
Author

Hi! I accidentally pushed a commit meant for a different issue into this branch, I have force-pushed to remove it, so this PR is now back to just the README link fix.
Please ignore the outdated modified CodeRabbit summary above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - README - Broken Slack link in community section

2 participants