feat(ContextSelector): Convert context selector to typescript - #2147
Merged
Conversation
Collaborator
|
PatternFly-React preview: https://2147-pr-patternfly-react-patternfly.surge.sh |
Codecov Report
@@ Coverage Diff @@
## master #2147 +/- ##
=========================================
+ Coverage 80.59% 80.6% +0.01%
=========================================
Files 666 666
Lines 8440 8523 +83
Branches 719 737 +18
=========================================
+ Hits 6802 6870 +68
- Misses 1280 1288 +8
- Partials 358 365 +7
Continue to review full report at Codecov.
|
redallen
suggested changes
Jun 5, 2019
redallen
previously approved these changes
Jun 7, 2019
dlabaj
reviewed
Jun 10, 2019
dlabaj
reviewed
Jun 10, 2019
| onEnterPressed = (event: any) => { | ||
| if (event.charCode === KEY_CODES.ENTER) { | ||
| this.props.onSearchButtonClick(); | ||
| this.props.onSearchButtonClick(null); |
Contributor
There was a problem hiding this comment.
You shouldn't have to pass null here...
Contributor
Author
There was a problem hiding this comment.
I was running into a typescript error about it which is why I added it, but I can make the event argument optional instead so that null isn't passed.
Contributor
|
LGTM |
dlabaj
approved these changes
Jun 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2146