Skip to content

fix(table): add lodash-es as a dependency#2228

Merged
tlabaj merged 1 commit into
patternfly:masterfrom
redallen:fix/react-table-lodash
Jun 12, 2019
Merged

fix(table): add lodash-es as a dependency#2228
tlabaj merged 1 commit into
patternfly:masterfrom
redallen:fix/react-table-lodash

Conversation

@redallen

Copy link
Copy Markdown
Contributor

What: Fixes #2222

Additional issues:

@patternfly-build

Copy link
Copy Markdown
Collaborator

PatternFly-React preview: https://2228-pr-patternfly-react-patternfly.surge.sh

@priley86

Copy link
Copy Markdown
Member

thanks! i think OpenShift has lodash-es as a hard dep already, so i wasn't seeing this. No issues w/ making it a dep here though.

@tlabaj tlabaj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tlabaj tlabaj merged commit 7df0e42 into patternfly:master Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

React table throws Can't resolve lodash-es in v2.11.1

5 participants