Skip to content

docs(Table Filter Demo) #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tlabaj merged 8 commits into from
Oct 25, 2019
Merged

docs(Table Filter Demo) #3127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f61e2d5
feat(FilterTableDemo): add demo of filterable table
kmcfaul Oct 10, 2019
af0380e
feat(FilterTable demo): update name search input to clear after selec…
kmcfaul Oct 11, 2019
45093ee
feat(FilterTable demo): remove old example code
kmcfaul Oct 11, 2019
e3b3fd6
feat(FilterTable demo): update snapshot with rebase
kmcfaul Oct 11, 2019
ef5baaa
feat(FilterTable demo): add pr feedback, rebase master, update snapshots
kmcfaul Oct 22, 2019
b604247
feat(FilterTable demo): add empty state when filters return no rows
kmcfaul Oct 23, 2019
f479db8
feat(FilterTable demo): add responsive toggle, remove width limits
kmcfaul Oct 23, 2019
cc4834b
feat(FilterTable demo): add docs note to mention DataToolbar component
kmcfaul Oct 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/patternfly-4/react-core/src/components/Select/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,8 @@ class Select extends React.Component<SelectProps & InjectedOuiaProps, SelectStat
toggleIcon,
ouiaContext,
ouiaId,
createText,
noResultsFoundText,
...props
} = this.props;
const { openedOnEnter, typeaheadInputValue, typeaheadActiveChild } = this.state;
Expand All @@ -374,6 +376,7 @@ class Select extends React.Component<SelectProps & InjectedOuiaProps, SelectStat
</ChipGroup>
);
}

return (
<div
className={css(
Expand Down
32 changes: 0 additions & 32 deletions packages/patternfly-4/react-core/src/components/Select/__snapshots__/Select.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,12 +422,10 @@ exports[`checkbox select renders checkbox select groups successfully - old class
aria-labelledby=""
checked=""
className=""
createText="Create"
isExpanded={false}
isGrouped={true}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -1204,12 +1202,10 @@ exports[`checkbox select renders checkbox select groups successfully 1`] = `
aria-labelledby=""
checked=""
className=""
createText="Create"
isExpanded={false}
isGrouped={true}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -2293,12 +2289,10 @@ exports[`checkbox select renders expanded successfully - old classes 1`] = `
aria-labelledby=""
checked=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -2768,12 +2762,10 @@ exports[`checkbox select renders expanded successfully 1`] = `
aria-labelledby=""
checked=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -3252,12 +3244,10 @@ exports[`checkbox select renders expanded successfully with custom objects 1`] =
aria-labelledby=""
checked=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -3731,12 +3721,10 @@ exports[`select custom select filter filters properly 1`] = `
aria-label=""
aria-labelledby=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -4266,12 +4254,10 @@ exports[`select renders select groups successfully 1`] = `
aria-label=""
aria-labelledby=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -5570,12 +5556,10 @@ exports[`select single select renders expanded successfully 1`] = `
aria-label=""
aria-labelledby=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -6004,12 +5988,10 @@ exports[`select single select renders expanded successfully with custom objects
aria-label=""
aria-labelledby=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -6764,12 +6746,10 @@ exports[`typeahead multi select renders expanded successfully 1`] = `
aria-label=""
aria-labelledby=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -7729,12 +7709,10 @@ exports[`typeahead multi select renders selected successfully 1`] = `
aria-label=""
aria-labelledby=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected={
Array [
Expand Down Expand Up @@ -8226,12 +8204,10 @@ exports[`typeahead multi select test onChange 1`] = `
aria-label=""
aria-labelledby=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -8859,12 +8835,10 @@ exports[`typeahead select renders expanded successfully 1`] = `
aria-label=""
aria-labelledby=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -9399,12 +9373,10 @@ exports[`typeahead select renders selected successfully 1`] = `
aria-label=""
aria-labelledby=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected="Mr"
sendRef={[Function]}
Expand Down Expand Up @@ -9862,12 +9834,10 @@ exports[`typeahead select test creatable option 1`] = `
aria-label=""
aria-labelledby=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down Expand Up @@ -10203,12 +10173,10 @@ exports[`typeahead select test onChange 1`] = `
aria-label=""
aria-labelledby=""
className=""
createText="Create"
isExpanded={false}
isGrouped={false}
keyHandler={[Function]}
maxHeight=""
noResultsFoundText="No results found"
openedOnEnter={false}
selected=""
sendRef={[Function]}
Expand Down
Loading