docs(table): add empty state and spinner to pagination table demo - #3232
Closed
boaz0 wants to merge 1 commit into
Closed
docs(table): add empty state and spinner to pagination table demo#3232boaz0 wants to merge 1 commit into
boaz0 wants to merge 1 commit into
Conversation
Signed-off-by: Boaz Shuster <boaz.shuster.github@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3232 +/- ##
=======================================
Coverage 67.44% 67.44%
=======================================
Files 892 892
Lines 24872 24872
Branches 2142 2142
=======================================
Hits 16774 16774
Misses 7093 7093
Partials 1005 1005
Continue to review full report at Codecov.
|
Collaborator
|
PatternFly-React preview: https://patternfly-react-pr-3232.surge.sh |
dlabrecq
suggested changes
Nov 5, 2019
| page: 1, | ||
| error: null, | ||
| loading: true | ||
| loading: false |
Member
There was a problem hiding this comment.
I'm not able to see the spinner. Thinking loading should be true initially?
| <EmptyStateIcon icon={TimesIcon} /> | ||
| <Title size="lg">Failed to fetch data</Title> | ||
| </EmptyState> | ||
| </Bullseye> |
Member
There was a problem hiding this comment.
I'm not able to see this empty state. How does the user see an empty state with this demo?
Perhaps we can add a toggle?
Member
Author
|
closing this in favor of #3294 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What:
closes #3184