fix(Table): fix dual-imports between files#378
Merged
Conversation
affects: patternfly-react
priley86
approved these changes
Jun 1, 2018
Member
|
@sharvit thanks - i didn't experience this downstream in v2v (not sure why), but i take your word for it. I think this is a better approach. This should be no impact if you are using |
jeff-phillips-18
approved these changes
Jun 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
affects: patternfly-react
What:
The
index.jsimporting files that importing theindex.jsitself.I don't think it's a good idea to do so and it may be dangerous.
Foreman nightlies assets are broken at the moment, we are not sure why but I got some confidence it is related to the dual-importing issue.
https://community.theforeman.org/t/nightlies-assets-are-now-broken/9810
Link to Storybook:
https://rawgit.com/sharvit/patternfly-react/storybook/fix/table-importing/index.html?selectedKind=patternfly-react%2FContent%20Views%2FTable%20View&selectedStory=PatternFly%20Table%20Styles&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybooks%2Fstorybook-addon-knobs