FEATURE: validate liquid templates on wizard save

[fzngagan]

No description provided.

[fzngagan]

@angusmcleod
I've made the backend validation to work properly. The frontend needs some changes to display the errors correctly. Will continue with those later in the week.

[lgtm-com]

This pull request introduces 1 alert when merging 12b2935 into c9e243f - view on LGTM.com

new alerts:

• 1 for Useless assignment to local variable

[fzngagan]

@angusmcleod
There was an issue(which I've fixed in the last commit) where the server side validation errors wouldn't display on the frontend. Here's why.

Scenario 1

When you call wizard.save like

discourse-custom-wizard/assets/javascripts/discourse/controllers/admin-wizards-wizard-show.js.es6

Line 78 in 1119218

.save(opts)

It rejects the promise if the buildJson method returns wizard.error.

discourse-custom-wizard/assets/javascripts/discourse/models/custom-wizard.js.es6

Line 14 in 1119218

if (wizard.error) {

and hence we enter the catch block of the calling method

discourse-custom-wizard/assets/javascripts/discourse/controllers/admin-wizards-wizard-show.js.es6

Line 82 in 1119218

.catch((result) => {

without even hitting the server.

Scenario 2

Let's say the promise didn't get rejected, in that case we enter

discourse-custom-wizard/assets/javascripts/discourse/models/custom-wizard.js.es6

Line 31 in 1119218

if (result.error) {

Now this condition would never be satisfied because we return the key errors and not error from the server.

discourse-custom-wizard/controllers/custom_wizard/admin/wizard.rb

Line 40 in c9e243f

render json: failed_json.merge(errors: template.errors.full_messages)

The last commit fixes this issue.

[lgtm-com]

This pull request introduces 1 alert when merging 2cfd827 into c9e243f - view on LGTM.com

new alerts:

• 1 for Useless assignment to local variable

[fzngagan]

Note: the issue reported by LGTM.com is fixed in the last commit.