[TASK-8092] fix: upgrade reown version 🫠 + fix chains#612
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThis pull request introduces updates to the project's configuration and dependency management. The changes focus on modifying the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/constants/chains.consts.ts (1)
98-106: Explicit chain definitions improve clarityThe change from spreading all chains to explicitly listing them provides better control and visibility over supported chains.
Consider grouping chains by network type (L1s, L2s, sidechains) for better organization:
export const chains = [ + // Layer 1 Networks wagmiChains.mainnet, + wagmiChains.bsc, + + // Layer 2 Networks wagmiChains.optimism, wagmiChains.arbitrum, wagmiChains.base, wagmiChains.scroll, wagmiChains.mantle, + + // Side Chains wagmiChains.gnosis, wagmiChains.polygon, - wagmiChains.scroll, - wagmiChains.mantle, - wagmiChains.arbitrum, - wagmiChains.bsc,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (3)
package.json(1 hunks)src/config/wagmi.config.tsx(1 hunks)src/constants/chains.consts.ts(2 hunks)
🔇 Additional comments (2)
package.json (1)
31-32: Verify stability of release candidate versionsBoth
@reown/appkitand@reown/appkit-adapter-wagmiare being updated to release candidate versions (1.6.4-rc.2.0). While this aligns with the PR objective of upgrading reown, RC versions might not be suitable for production use.Please confirm:
- Are these RC versions stable enough for production?
- Are there any breaking changes in these versions?
- Have these versions been tested in a staging environment?
src/config/wagmi.config.tsx (1)
63-63: Configuration change aligns with reown upgradeThe change from boolean flags to an ordered array provides better control over connection methods. This appears to be a breaking change introduced in the new reown version.
Please ensure that:
- The order ['wallet', 'email', 'social'] matches the intended user experience
- All connection methods mentioned in the array are properly configured
| @@ -95,7 +95,15 @@ const ZKSyncSepolia = { | |||
|
|
|||
| //@ts-ignore | |||
| export const chains = [ | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Remove @ts-ignore comment
The @ts-ignore comment suggests potential type issues. This should be properly typed instead of suppressing the error.
Let's investigate and fix the type issue. Could you share the TypeScript error that necessitated this comment?
Summary by CodeRabbit
Dependencies
@reown/appkitto version1.6.4-rc.2.0@reown/appkit-adapter-wagmito version1.6.4-rc.2.0Configuration