Skip to content

[TASK-8092] fix: upgrade reown version 🫠 + fix chains#612

Merged
Hugo0 merged 1 commit intodevelopfrom
fix/appkit
Jan 9, 2025
Merged

[TASK-8092] fix: upgrade reown version 🫠 + fix chains#612
Hugo0 merged 1 commit intodevelopfrom
fix/appkit

Conversation

@kushagrasarathe
Copy link
Copy Markdown
Contributor

@kushagrasarathe kushagrasarathe commented Jan 8, 2025

Summary by CodeRabbit

  • Dependencies

    • Updated @reown/appkit to version 1.6.4-rc.2.0
    • Updated @reown/appkit-adapter-wagmi to version 1.6.4-rc.2.0
  • Configuration

    • Modified connection methods order in Wagmi configuration
    • Updated supported blockchain chains list with explicit chain selections

@kushagrasarathe kushagrasarathe requested a review from Hugo0 January 8, 2025 18:23
@vercel
Copy link
Copy Markdown

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
peanut-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 6:27pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Jan 8, 2025

Walkthrough

This pull request introduces updates to the project's configuration and dependency management. The changes focus on modifying the package.json file to update dependency versions for @reown/appkit and @reown/appkit-adapter-wagmi. Additionally, the wagmi.config.tsx file is updated to change the connection methods configuration, and the chains.consts.ts file is modified to explicitly define specific blockchain chains instead of using a spread operator.

Changes

File Change Summary
package.json - Updated @reown/appkit from 1.6.4-rc.0 to 1.6.4-rc.2.0
- Updated @reown/appkit-adapter-wagmi from ^1.6.0 to 1.6.4-rc.2.0
src/config/wagmi.config.tsx - Replaced email and socials properties with connectMethodsOrder
- Set connection methods order to ['wallet', 'email', 'social']
src/constants/chains.consts.ts - Changed import of wagmiChains from type import to standard import
- Explicitly defined specific chains from wagmiChains

Possibly related PRs

Suggested reviewers

  • Hugo0

Poem

🐰 Hop, hop, through config's maze,
Dependencies dance in version's craze,
Chains aligned, methods in order neat,
A rabbit's code update - oh so sweet! 🔧
Wagmi config sings a new refrain! 🎉


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@notion-workspace
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
src/constants/chains.consts.ts (1)

98-106: Explicit chain definitions improve clarity

The change from spreading all chains to explicitly listing them provides better control and visibility over supported chains.

Consider grouping chains by network type (L1s, L2s, sidechains) for better organization:

 export const chains = [
+    // Layer 1 Networks
     wagmiChains.mainnet,
+    wagmiChains.bsc,
+    
+    // Layer 2 Networks
     wagmiChains.optimism,
     wagmiChains.arbitrum,
     wagmiChains.base,
     wagmiChains.scroll,
     wagmiChains.mantle,
+    
+    // Side Chains
     wagmiChains.gnosis,
     wagmiChains.polygon,
-    wagmiChains.scroll,
-    wagmiChains.mantle,
-    wagmiChains.arbitrum,
-    wagmiChains.bsc,
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7493f45 and 1f9890f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • package.json (1 hunks)
  • src/config/wagmi.config.tsx (1 hunks)
  • src/constants/chains.consts.ts (2 hunks)
🔇 Additional comments (2)
package.json (1)

31-32: Verify stability of release candidate versions

Both @reown/appkit and @reown/appkit-adapter-wagmi are being updated to release candidate versions (1.6.4-rc.2.0). While this aligns with the PR objective of upgrading reown, RC versions might not be suitable for production use.

Please confirm:

  1. Are these RC versions stable enough for production?
  2. Are there any breaking changes in these versions?
  3. Have these versions been tested in a staging environment?
src/config/wagmi.config.tsx (1)

63-63: Configuration change aligns with reown upgrade

The change from boolean flags to an ordered array provides better control over connection methods. This appears to be a breaking change introduced in the new reown version.

Please ensure that:

  1. The order ['wallet', 'email', 'social'] matches the intended user experience
  2. All connection methods mentioned in the array are properly configured

@@ -95,7 +95,15 @@ const ZKSyncSepolia = {

//@ts-ignore
export const chains = [
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Remove @ts-ignore comment

The @ts-ignore comment suggests potential type issues. This should be properly typed instead of suppressing the error.

Let's investigate and fix the type issue. Could you share the TypeScript error that necessitated this comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants