Merged
Conversation
This was referenced Mar 25, 2026
Closed
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s packaging and CI configuration for the 0.12.11 release, moving from setup.py/requirements files to a PEP 621 pyproject.toml build and updating code annotations/docs across the package.
Changes:
- Migrates packaging metadata to
pyproject.toml(hatchling) and removessetup.py,MANIFEST.in, and legacy requirements files. - Updates CI workflows to install via extras (
.[test]), run pytest, and replace Black with Ruff checks/formatting. - Modernizes type hints and docstrings across core modules; updates CLIs to derive version via
importlib.metadata.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Removed legacy setuptools packaging entrypoint. |
| MANIFEST.in | Removed legacy sdist include rules (previously included templates/data). |
| requirements/requirements-*.txt | Removed legacy dependency lists in favor of pyproject.toml. |
| pyproject.toml | Adds PEP 621 project metadata, dependencies, build backend, and tooling config. |
| geofetch/utils.py | Typing/docstring modernization and return type annotations. |
| geofetch/geofetch.py | Typing/docstring modernization; signature annotations and minor formatting. |
| geofetch/finder.py | Typing/docstring modernization and clearer method contracts. |
| geofetch/const.py | Adds module docstring and type annotations for constants. |
| geofetch/cli.py | Switches CLI version source to importlib.metadata; help text tweaks. |
| geofetch/sraconvert.py | Switches --version to importlib.metadata; typing/docstring cleanup. |
| geofetch/_version.py | Removed static version constant module. |
| geofetch/init.py | Removes __version__ export; adds typed __author__/__all__. |
| .github/workflows/run-pytest.yml | Updates test matrix and installation to pip install ".[test]". |
| .github/workflows/python-publish.yml | Switches publishing build step to python -m build. |
| .github/workflows/black.yml | Replaces Black action with Ruff lint + format checks and expands triggers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modernizing code phase 1-6