Skip to content

Upstream updates bugfixes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 13, 2016
Merged

Upstream updates bugfixes #1

merged 6 commits into from
Apr 13, 2016

Conversation

@timvaillancourt
Copy link

@timvaillancourt timvaillancourt commented Apr 11, 2016

Fixes:

  1. Index counter bugfix from upstream.
  2. Improved version of my direct-connection fix (for replsets) from upstream.
  3. Updated the broken tests of upstream code, which was updated in upstream.
  4. mongos/replset/mongod logic in mongodb_collector.go moved to functions.
  5. Lots of code cleanup, added logging, etc.

@timvaillancourt timvaillancourt mentioned this pull request Apr 11, 2016
Closed
dbmurphy
dbmurphy reviewed Apr 13, 2016
View reviewed changes
collector/mongod/index_counters.go
//IndexCounterStats index counter stats
type IndexCounterStats struct {
Accesses float64 `bson:"accesses`
Accesses float64 `bson:"accesses"`
Copy link

@dbmurphy dbmurphy Apr 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did this ever work?

Copy link
Author

@timvaillancourt timvaillancourt Apr 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not entirely sure of the inner workings here but I think it would not match the bson output and therefore always report accesses as zero, but I am not 100% sure. Structs seem very forgiving of missing/undefined fields

@dbmurphy dbmurphy merged commit 5066af5 into percona:master Apr 13, 2016
@timvaillancourt timvaillancourt deleted the upstream_updates_bugfixes branch April 13, 2016 15:17
@FENG-MASTER FENG-MASTER mentioned this pull request Jan 11, 2023
Closed
@theodrim theodrim mentioned this pull request Jun 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@timvaillancourt @dbmurphy