Skip to content
This repository was archived by the owner on Jun 25, 2026. It is now read-only.

added check for topLevelNodes in the category.xml#40

Merged
natechadwick merged 2 commits into
developmentfrom
CMS-7728
Feb 13, 2021
Merged

added check for topLevelNodes in the category.xml#40
natechadwick merged 2 commits into
developmentfrom
CMS-7728

Conversation

@mariosm1

Copy link
Copy Markdown
Contributor

No description provided.

@natechadwick natechadwick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matomario8 Can you update so that you are using === instead of ==, intellij gives a bunch of warnings for this file on that.

@sonyDeswal

Copy link
Copy Markdown

@matomario8 is it sure that we will have x[1]? Can x be of length 0 and will give outOfIndex error?

@natechadwick natechadwick left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@natechadwick
natechadwick merged commit b622f22 into development Feb 13, 2021
@sonyDeswal
sonyDeswal deleted the CMS-7728 branch February 19, 2021 04:22
natechadwick added a commit that referenced this pull request May 24, 2021
added check for topLevelNodes in the category.xml
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants