This repository was archived by the owner on Jun 25, 2026. It is now read-only.
javascript fixes & made 'www.' optional in social button links#79
Merged
Conversation
natechadwick
left a comment
natechadwick
left a comment
Member
There was a problem hiding this comment.
I wish we had tests for these so we could add a unit test for the regex. I made one comment on the keycode / mobile. We could backlog that to a seperate fix, but should make sure jira gets added. If you can check those out / reply we can merge.
natechadwick
approved these changes
Apr 5, 2021
natechadwick
added a commit
that referenced
this pull request
May 24, 2021
javascript fixes & made 'www.' optional in social button links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.