Skip to content

This removes the unneeded "zoom" for IE7#316

Merged
peterramsing merged 2 commits intomasterfrom
remove-unneeded-zoom
Jul 7, 2016
Merged

This removes the unneeded "zoom" for IE7#316
peterramsing merged 2 commits intomasterfrom
remove-unneeded-zoom

Conversation

@peterramsing
Copy link
Copy Markdown
Owner

@peterramsing peterramsing commented Jul 6, 2016

What kind of change is this? (Bug Fix, Feature...)

  • Cleanup

What is the current behavior (You can also link to an issue)

  • zoom: 1 was used and it clutters the syntax

What is the new behavior this introduces (if any)

  • zoom: 1 has been removed

Does this introduce any breaking changes?

  • Only if you're using IE7, which isn't supported by LostGrid. It was determined this wasn't a breaking change because of the inherent lack of support for IE7.

Does the PR fulfill these requirements?

  • Tests for the changes have been added
  • [N/A] Docs have been added or updated

Other Comments

Because IE7 support is not offered for calc(), the zoom: 1 isn't needed and
simply clutters up the syntax. As seen in #222
@peterramsing
Copy link
Copy Markdown
Owner Author

@wbruno How does this look regarding removing the zoom: 1? I want to do some more smoke testing and reading just to make sure the assumptions about zoom: 1 are indeed accurate. There are a lot of users of LostGrid and it is worth it to be prudent. 👍🏻

@wbruno
Copy link
Copy Markdown
Contributor

wbruno commented Jul 6, 2016

looks perfect!
I did some researching and zoom: 1 its really a old IE. thing.

@peterramsing
Copy link
Copy Markdown
Owner Author

@corysimmons
Copy link
Copy Markdown
Contributor

Yeah, I had a habit of trying to support anything I could but the IE7 zoom is silly since the best we can get with the polyfill is IE8. Good call. Old branch can be deleted right?

@peterramsing peterramsing deleted the remove-unneeded-zoom branch July 9, 2016 10:11
@peterramsing
Copy link
Copy Markdown
Owner Author

@corysimmons Branch deleted. 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants