Conversation
* Updates lost-center * Updates lost-masonry-wrap * Updates lost-utility
|
@corysimmons @wyze Do you think that this issue regarding the test is a blocker or something to be addressed in a larger project later? |
|
Your call. I'd advise against merging stuff that breaks tests in any way unless you have a really thorough understanding of what is breaking the test. /$.02 |
|
@corysimmons Sounds good. I'm going to dive a bit deeper. This is a 7.0 thing so it can certainly wait. |
|
You mentioned wanting to test the AST, so I looked into how to approach that. You would need to modify I would probably move the assertion out and do it in each test individually since testing the AST is more involved than a simple string check. In case you were curious, the reason for the current testing structure as I wasn't sure how people were testing PostCSS plugins, so I checked out a few and saw what they did and mimicked it. |
|
I was actually just looking at PostCSS's autoprefixer yesterday and you're right-they test the way you made it. I'll look into this further. |
* Addresses #249 by removing the grid comparison table * Removes 6.7.0 roadmap since it has been released * Removes the transitional note
…n) | #153 * Updates tests to reflect this change * Updates the lost-column and lost-waffle to reflect change * Updates documentation to reflect this change
Fixes issue where older Android wouldn't support :nth-child(n)
Since Less 2.6 you don't need to escape custom at-rules anymore.
Updates README.md to reflect updates to Less
Fixes too much code generation in waffle grids. #256
No Breaking Changes. This simply updates the year and adds other developers to license.
For some reason I can't get NPM to download the beta changes. I'm not sure what is causing this so I'm bumping the version and publishing a new beta to ensure the latest changes are in. 👍
I think it's probably time I add myself as an author along with update the homepage. 👍
This does not only affect tests. This also makes a difference when building multiple postcss targets in sequence.
After #312, these "resets" are no longer necessary.
|
what do we need to merge this PR ? |
|
@wbruno I just need to update the tests. It hasn't been a deal-breaker so I haven't put much focus on it. I can finish it up for the next release. Are you experiencing any issues with it or just wanting less code? |
|
I have to validate my css, at w3c. CEO orders. |
|
@wbruno The gist is that I was sort of hacking the tests around the code. That was right when I took over. I'll look too before I need to duck into the office. Maybe we can get a patch out... or is this a breaking change? Crumbs... |
|
Because there is no direction mention of IE7 support I don't believe this is a breaking change. Going to run this by a colleague to check my reasoning on that. |
|
Yep! it really doesn't make any sense, keep a ie7 hack, with |
|
@wbruno Hehe. This is so old the target branch isn't correct. Whoops. Going to close and open a new PR. |
Because IE7 support is not offered for calc(), the zoom: 1 isn't needed and simply clutters up the syntax. As seen in #222
8 participants
See #194 #135