T13208 validation messages#14193
Merged
niden merged 30 commits intophalcon:4.0.xfrom Jun 21, 2019
Merged
Conversation
# Conflicts: # CHANGELOG-4.0.md # phalcon/Validation/Validator/Identical.zep # tests/_data/fixtures/Traits/ValidationTrait.php # tests/integration/Validation/Validator/DateCest.php
niden
added
breaks bc
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14193 +/- ##
==========================================
- Coverage 66.32% 66.32% -0.01%
==========================================
Files 475 475
Lines 112047 111670 -377
==========================================
- Hits 74315 74062 -253
+ Misses 37732 37608 -124
Continue to review full report at Codecov.
|
niden
approved these changes
Jun 21, 2019
Member
|
Thank you @emiliodeg |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Moved default validation messages to validators
Thanks