T14488 column map#14566
Merged
niden merged 3 commits intophalcon:4.0.xfrom Dec 1, 2019
niden:T14488-column-map
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## 4.0.x #14566 +/- ##
==========================================
- Coverage 67.73% 67.73% -0.01%
==========================================
Files 488 488
Lines 112557 112566 +9
==========================================
+ Hits 76243 76249 +6
- Misses 36314 36317 +3 |
ruudboon
approved these changes
Dec 1, 2019
sergeyklay
approved these changes
Dec 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Fixed
Phalcon\Mvc\Model::cloneResultMapto correctly recognize aliased fields and include them in the resultsetThanks