Skip to content

T14858 folder name with period#14893

Merged
niden merged 6 commits intophalcon:4.0.xfrom
niden:T14858-folder-name-with-period
Mar 5, 2020
Merged

T14858 folder name with period#14893
niden merged 6 commits intophalcon:4.0.xfrom
niden:T14858-folder-name-with-period

Conversation

@niden
Copy link
Copy Markdown
Member

@niden niden commented Mar 5, 2020

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Str::dirFromFile() to replace . with - to avoid issues with Windows environments

Thanks

@niden niden added 4.0.5 bug A bug report status: low Low labels Mar 5, 2020
@niden niden merged commit da5e809 into phalcon:4.0.x Mar 5, 2020
@niden niden deleted the T14858-folder-name-with-period branch March 5, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A bug report status: low Low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant