[#15711] Fix toArray() and unserialize() for typed PHP properties that are uninitialized#16905
Merged
niden merged 3 commits intophalcon:5.0.xfrom Apr 23, 2026
Merged
Conversation
…ze property assignment loop for typed properties
Jeckerson
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
Root Cause
When a query result (e.g. from a LEFT JOIN with no matching row) returns
NULLfor a column that isNOT NULLin the database schema,cloneResultMap()deliberately skips the property assignment to avoid aTypeError. This leaves any typed non-nullable PHP property (e.g.public int $inv_id) uninitialized.Two downstream failures then occur:
Bug 1 —
toArray()with a getterIf the model defines a getter for the property (e.g.
getInvId()), callingtoArray()with the defaultuseGetter = trueinvokes that getter, which reads the uninitialized typed property and throws:This is the error reported in the issue stack trace (occurring during
Apcu->set()on the first request).Bug 2 —
unserialize()Because
toArray()returnsnullfor an uninitialized property (via theisset()fallback path), the serialised data storesinv_id => null. On the next request,unserialize()tries to assign that null back topublic int $inv_id, throwing:Fixes
Model::toArray(): wrap the getter call intry/catch \Errorso that accessing an uninitialized typed property through a getter returnsnullinstead of propagating.Model::unserialize(): wrap each property assignment intry/catch \TypeErrorso that restoring anullvalue into a typed non-nullable property is silently skipped rather than crashing.Thanks