Merged
Conversation
…espaced models When building a complex resultset from SELECT * or SELECT alias.*, the balias key used to access the model object inside a Row was always computed with lcfirst(modelName). For namespaced models this produced an unintuitive and hard-to-predict key (e.g. app\Models\Users instead of App\Models\Users). Non-namespaced models (e.g. Robots -> robots) are unaffected. Fixes phalcon#16052
…gh and has one through
niden
added
breaks bc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Fixed
Phalcon\Mvc\ModelNOT NULL validation to accept empty strings""for string columns (VARCHAR,CHAR,TEXT); previously""was incorrectly treated asnulland triggered aPresenceOfvalidation error. Applications relying on this implicit rejection of empty strings must add an explicitPresenceOforStringLength(min=1)validatorThanks