T17005 config cast#17010
Merged
Merged
Conversation
Assisted-by: Claude Code
Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Fixed
Phalcon\Support\Collection::get()returning the wrapping object's mangled property table when called with$cast = 'array'on a stored object (e.g. a nestedPhalcon\Config\Config, whichConfig::setData()wraps around every array value). The previous implementation calledsettype($value, 'array')unconditionally, which on an object exposes PHP's null-prefixed internal protected-property names ("\0*\0data","\0*\0lowerKeys", etc.) instead of the intended array form, so$config->get('outKey', [], 'array')['inKey']raisedNotice: Undefined index. The cast branch now special-cases'array'for objects exposing atoArray()method and delegates to that method; scalar casts (int,bool,float,string,null,object) and'array'on a plainstdClass(notoArray()) are unchangedThanks