Skip to content

T17052 di magic get#17075

Merged
niden merged 6 commits into
5.0.xfrom
T17052-di-magic-get
Jun 5, 2026
Merged

T17052 di magic get#17075
niden merged 6 commits into
5.0.xfrom
T17052-di-magic-get

Conversation

@niden
Copy link
Copy Markdown
Member

@niden niden commented Jun 5, 2026

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Di\Injectable::__get() to no longer cache resolved services as dynamic object properties. Services accessed via magic properties (e.g. $this->request) are now re-resolved through the container on each access, so replacing or updating a service in the container is reflected in controllers, views, and other injectable classes. Properties already declared on the class continue to be populated.

Thanks

@niden niden requested a review from Jeckerson June 5, 2026 14:15
@niden niden self-assigned this Jun 5, 2026
@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Jun 5, 2026
@niden niden changed the base branch from master to 5.0.x June 5, 2026 14:15
Assisted-by: Claude Code
@niden niden merged commit f1b8432 into 5.0.x Jun 5, 2026
192 checks passed
@niden niden deleted the T17052-di-magic-get branch June 5, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants