T5 generators - #6
Merged
Merged
Conversation
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Assisted-by: Claude Code
Closed
Code Metrics Report
Details | | master (72ea7bd) | #6 (f5535e5) | +/- |
|---------------------|------------------|--------------|-------|
+ | Coverage | 98.6% | 98.8% | +0.1% |
| Files | 31 | 40 | +9 |
| Lines | 736 | 936 | +200 |
+ | Covered | 726 | 925 | +199 |
| Test Execution Time | 1s | 1s | 0s |Code coverage of files in pull request scope (98.3% → 98.6%)Reported by octocov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
composer test,composer csandcomposer analyzeall passAdded
make:command, generating a crest command for a package that contributes its own. Prints theextra.crest.commandsblock to declare it with, since that is the only way the registry finds a command.Added
make:middleware, generating an ADR middleware and printing the router middleware-map entry that activates it.Added
make:provider, generating a service provider forPhalcon\Containerand printing theregisterProviders()override that calls it.Added
make:responder, generating an ADR responder that implements theRespondercontract directly.Added
stub:publish, copying packaged stubs intoresources/stubs/<flavor>/so a project can edit them. The override chain already worked; nothing made it discoverable.Added
--stubtomake:action, rendering any named stub instead of the--responderdefault. Passing both is rejected rather than silently resolved.Added
command,middleware,providerandresponderto the defaultpathsincrest.php, alongsideaction. Each is overridable per project as before.Added
Crest\Command\ProjectCommand, the base for commands that read the project being run against. Contributed commands can extend it for--directoryand--confighandling instead of resolving those options themselves.Added
Crest\Generator\ClassName::suffixed(), which appends an artifact suffix idempotently, somake:middleware Corsandmake:middleware CorsMiddlewareboth produceCorsMiddleware.Default
pathsare now per flavor rather than shared. Onlyadris populated, so acliormvcproject is no longer offered directories for artifacts it has no command to generate.crest,crest listandcrest --versionnow open with a chevron mark before the name and version. Only the color is dropped from piped output and whenNO_COLORis set; the glyph stays.make:middleware,make:providerandmake:responderno longer generate a class that cannot be parsed when the name given is already the suffix.make:middleware Middlewareproducedfinal class Middleware implements Middlewarebesideuse ...\Middleware;. The contract is now imported under an alias.Generators now fail instead of reporting a file they did not write. A target that could not be created produced two PHP warnings,
Created <file>and exit 0; it now reportscould not create <directory>and exits 1.stub:publishnow rejects a name that is a path.stub:publish ../../elsewhere/thingresolved and copied a file from outside the package.ClassName::suffixed()now accepts non-Latin class names, matching PHP's own rule for an identifier.Removed the shadowed-action warning from
make:action. One path names exactly one Action, so nothing can be shadowed.Removed the
phalcon/cli-options-parserrequirement. Crest never linked against it: the schema-aware definition layer stays inCrest\Console\Parsing, sinceCop\Parseris schema-less by design.Thanks