Move 'Color>>random: aSeed' in Pharo

[LabordePierre]

I think it make sens to move 'Color>>random: aSeed' into Pharo core, instead of to be an Alexandrie extension (and in addition in Tests packages ).

See: OpenSmock/OpenSmock#103

[tinchodias]

I think this is the only extension to Color in this repo: https://github.com/pharo-graphics/Alexandrie/blob/dev/src/Alexandrie-Cairo/Color.extension.st

[tinchodias]

Ah, it is in Bloc-Alexandrie: https://github.com/pharo-graphics/Bloc/blob/fba3f13da96c81ac612089687f8255eb5f7705ac/src/Bloc-Alexandrie-Tests/Color.extension.st

[tinchodias]

The 0.3 and 0.4 may be too arbitrary for general use:

Bloc/src/Bloc-Alexandrie-Tests/Color.extension.st

Lines 4 to 12 in fba3f13

	Color class >> random: aRandom [
	"Return a random color that isn't too dark or under-saturated."
	^ self
	h: (360.0 * aRandom next)
	s: (0.3 + (aRandom next * 0.7))
	v: (0.4 + (aRandom next * 0.6))
	]

[LabordePierre]

Ah, it is in Bloc-Alexandrie: https://github.com/pharo-graphics/Bloc/blob/fba3f13da96c81ac612089687f8255eb5f7705ac/src/Bloc-Alexandrie-Tests/Color.extension.st

Sorry @tinchodias I made the ticket in the wrong project :/ thanks for the moving.

[LabordePierre]

The 0.3 and 0.4 may be too arbitrary for general use:

Bloc/src/Bloc-Alexandrie-Tests/Color.extension.st

Lines 4 to 12 in fba3f13

Color class >> random: aRandom [
"Return a random color that isn't too dark or under-saturated."

^ self
h: (360.0 * aRandom next)
s: (0.3 + (aRandom next * 0.7))
v: (0.4 + (aRandom next * 0.6))

]

You have right, it looks like magic numbers :)

[LabordePierre]

I addded methods here: OpenSmock/OpenSmock#103
Color>>randomRGB
Color>>randomRGBA
Color>>randomRGB: aRandom
Color>>randomRGBA: aRandom

This is ok while waiting for this.

[tinchodias]

Pierre, in fact this method was not used in Bloc. So I deprecated it, and the ones in OpenSmock are fine. Also, you will be able to tune the arbitrary values without risk of breaking other users.

[LabordePierre]

Hi @tinchodias, ok thanks a lot :)

[tinchodias]

thank you